Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve Flask Prometheus Metrics; Relock Dependencies #46

Merged
merged 8 commits into from
Oct 24, 2023

Conversation

KPrasch
Copy link
Member

@KPrasch KPrasch commented Oct 24, 2023

Type of PR:
Feature

Required reviews:
1

What this does:

  • Introduces https://pypi.org/project/prometheus-flask-exporter/ with a path counter
  • Relock dependencies for an updated nucypher-core (v0.10.3) and nucypher (v7.0.0-rc.3)
  • Indicate minimum python version as 3.9 and maximum as 3.11
  • Run CI jobs on python 3.9 and 3.11

@KPrasch KPrasch changed the title Development Serve Flask Prometheus Metrics Oct 24, 2023
requirements.txt Outdated Show resolved Hide resolved
Pipfile Outdated Show resolved Hide resolved
@KPrasch KPrasch changed the title Serve Flask Prometheus Metrics Serve Flask Prometheus Metrics; Relock Dependencies Oct 24, 2023
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 - See suggestion in gh action for python version.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
Co-authored-by: Derek Pierre <derek.pierre@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #46 (9080f8d) into development (f387124) will increase coverage by 0.02%.
Report is 12 commits behind head on development.
The diff coverage is 96.96%.

@@               Coverage Diff               @@
##           development      #46      +/-   ##
===============================================
+ Coverage        87.87%   87.89%   +0.02%     
===============================================
  Files               18       18              
  Lines              709      719      +10     
===============================================
+ Hits               623      632       +9     
- Misses              86       87       +1     
Files Coverage Δ
porter/__about__.py 100.00% <100.00%> (ø)
porter/cli/main.py 97.91% <100.00%> (ø)
porter/fields/taco.py 100.00% <ø> (ø)
porter/interfaces.py 97.43% <100.00%> (ø)
porter/schema.py 98.64% <100.00%> (ø)
porter/main.py 88.11% <94.73%> (+0.14%) ⬆️

@KPrasch KPrasch merged commit 40a9592 into nucypher:development Oct 24, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants