Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons for Cisco AnyConnect #5260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Icons for Cisco AnyConnect #5260

wants to merge 1 commit into from

Conversation

maxtron95
Copy link
Contributor

Fixes #2820

anyconnect-ci
anyconnect-sq

@maxtron95 maxtron95 requested review from Foggalong and palob as code owners May 5, 2020 18:48
palob
palob requested changes May 5, 2020
View reviewed changes
Copy link
Member

@palob palob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid it is definitely too wide. Do you know how this design is related to the app?

@palob palob added the merge label May 5, 2020
@maxtron95
Copy link
Contributor Author

@palob From what I can tell, Cisco AnyConnect is a type of vpn. Shall I try adapting the original icon to this instead?

@palob
Copy link
Member

palob commented May 5, 2020

I'd say so but I'd also consider this a low prio issue since the icon is hardcoded anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palob palob palob requested changes

@Foggalong Foggalong Awaiting requested review from Foggalong

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon for Cisco AnyConnect
2 participants
@maxtron95 @palob