Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added winbox icon #5777

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added winbox icon #5777

wants to merge 1 commit into from

Conversation

ingria
Copy link
Contributor

@ingria ingria commented Feb 21, 2022 •
edited
Loading

Fixed crescent shapes and fitted them into 30px circle.

Original icon Circle icon Square icon

See also #5742, fixes #5740.

source svg

winbox

@ingria ingria changed the title Added winbox icon (fixes #5740) Added winbox icon Feb 21, 2022
@ingria
Copy link
Contributor Author

ingria commented Feb 21, 2022 •
edited
Loading

Just found this unofficial snap: https://snapcraft.io/winbox

Is it possible to support it too? Its .desktop file is here.

@palob palob added the merge label Feb 21, 2022
@ingria ingria force-pushed the winbox branch 2 times, most recently from 88ee37c to 95eae48 Compare February 21, 2022 14:51
@palob
Copy link
Member

palob commented Feb 21, 2022

No, as soon as there is a / in the Icon= line this means the icon path is hardcoded and you need to edit the .desktop file.

I know it's from the original PR but I don't think the .exe symlinks in data.json will work. They should be removed.

@ingria ingria force-pushed the winbox branch 2 times, most recently from 4a31b73 to 74f948f Compare February 21, 2022 20:42
@palob
Copy link
Member

palob commented Feb 26, 2022

Thank you for the PRs. There symbol should be smaller still (and moved up/to the right maybe) so that it fits into a centered 30x30 circle.

circcle

@mrmeszaros
Copy link
Contributor

mrmeszaros commented Sep 22, 2022 •
edited
Loading

The drop shadow seems off to me.
For the circle it is usually offset to the bottom right (1, 1).
For the square it is offset to the bottom (0, 1).

Also, just a heads up, You don't have to amend the commit and force-push - all commits on the branch are rebased and squashed into one when merging.

@palob
Copy link
Member

palob commented Dec 15, 2022

Additional icon name com.mikrotik.Winbox required.

@palob palob mentioned this pull request Feb 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Foggalong Foggalong Awaiting requested review from Foggalong

@palob palob Awaiting requested review from palob palob is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon Request: winbox
3 participants
@ingria @palob @mrmeszaros