Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias bitwise_not with invert #399

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Apr 6, 2022

bitwise_not is not documented in the NumPy documentation. The name bitwise_not is available, but it points to invert.

To reduce code duplication and to provide parity with NumPy, this PR:

  1. Aliases bitwise_not with invert
  2. Removes bitwise_not from the NumS documentation (invert remains in the NumS documentation).

See https://numpy.org/doc/stable/reference/generated/numpy.invert.html.

Closes #305

top_k
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOL was missing here.

@bveeramani bveeramani requested a review from elibol April 6, 2022 03:14
@bveeramani bveeramani self-assigned this Apr 6, 2022
Copy link
Member

@elibol elibol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a minor conflict. Otherwise LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nums.numpy.bitwise_not should be renamed nums.numpy.invert
2 participants