Skip to content

Commit

Permalink
Recognize assignments inside try/finally statements.
Browse files Browse the repository at this point in the history
  • Loading branch information
manfred-brands committed Sep 5, 2023
1 parent beb4407 commit 453fb53
Show file tree
Hide file tree
Showing 2 changed files with 83 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,51 @@ public void Test()
RoslynAssert.Suppressed(suppressor, testCode);
}

[Test]
public void FieldAssignedInTryFinally()
{
var testCode = TestUtility.WrapClassInNamespaceAndAddUsing(@"
public class BaseClass
{
[SetUp]
public virtual void SetUp()
{
}
[TearDown]
public virtual void TearDown()
{
}
}
public class TestClass : BaseClass
{
private string ↓field;
public override void SetUp()
{
base.SetUp();
try
{
field = string.Empty;
}
catch
{
base.TearDown();
}
}
[Test]
public void Test()
{
Assert.That(field, Is.Not.Null);
}
}
");

RoslynAssert.Suppressed(suppressor, testCode);
}

[Test]
public void PropertyNotAssigned()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,18 +127,49 @@ private static bool IsAssignedIn(
return IsAssignedIn(model, classDeclaration, method.ExpressionBody.Expression, fieldOrPropertyName);
}

if (method.Body is null)
if (method.Body is not null)
{
return false;
return IsAssignedIn(model, classDeclaration, method.Body, fieldOrPropertyName);
}

foreach (var statement in method.Body.Statements)
return false;
}

private static bool IsAssignedIn(
SemanticModel model,
ClassDeclarationSyntax classDeclaration,
StatementSyntax statement,
string fieldOrPropertyName)
{
switch (statement)
{
if (statement is ExpressionStatementSyntax expressionStatement &&
IsAssignedIn(model, classDeclaration, expressionStatement.Expression, fieldOrPropertyName))
{
case ExpressionStatementSyntax expressionStatement:
return IsAssignedIn(model, classDeclaration, expressionStatement.Expression, fieldOrPropertyName);

case BlockSyntax block:
return IsAssignedIn(model, classDeclaration, block.Statements, fieldOrPropertyName);

case TryStatementSyntax tryStatement:
return IsAssignedIn(model, classDeclaration, tryStatement.Block, fieldOrPropertyName) ||
(tryStatement.Finally is not null &&
IsAssignedIn(model, classDeclaration, tryStatement.Finally.Block, fieldOrPropertyName));

default:
// Any conditional statement does not guarantee assignment.
return false;
}
}

private static bool IsAssignedIn(
SemanticModel model,
ClassDeclarationSyntax classDeclaration,
SyntaxList<StatementSyntax> statements,
string fieldOrPropertyName)
{
foreach (var statement in statements)
{
if (IsAssignedIn(model, classDeclaration, statement, fieldOrPropertyName))
return true;
}
}

return false;
Expand Down

0 comments on commit 453fb53

Please sign in to comment.