Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add macos, linux in ci #513

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

chore: add macos, linux in ci #513

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4a1c625
chore: add macos, linux in ci
get-me-power Feb 2, 2023
8706511
chore: delete net462
get-me-power Feb 4, 2023
552b72c
chore: Specify per-os tests on ci
get-me-power Feb 5, 2023
283e5b2
chore: fix syntax error
get-me-power Feb 5, 2023
7b8b0e3
chore: update ci
get-me-power Feb 5, 2023
aafb641
fix: typo
get-me-power Feb 5, 2023
4a4e692
chore: add octocov to get code coverage
get-me-power Feb 6, 2023
3d6e3f4
chore: fix ci config
get-me-power Feb 6, 2023
41ae50e
chore: global install
get-me-power Feb 6, 2023
8b58436
chore: add codecoverage's lib
get-me-power Feb 6, 2023
c7f1005
chore: octocov support for only linux
get-me-power Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ on:

jobs:
build:
runs-on: windows-latest
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@main
- name: Setup .NET
Expand Down
2 changes: 1 addition & 1 deletion src/nunit.analyzers.tests/nunit.analyzers.tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<RootNamespace>NUnit.Analyzers.Tests</RootNamespace>
<TargetFrameworks>net6.0;net462</TargetFrameworks>
<TargetFramework>net6.0</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be done conditionally on OS. We still want to test .net framework on Windows

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your suggestion.
Therefore, I changed only ci.yml like this.
552b72c

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can test .NET and .NET Framework on windows, and .NET test on unix.

</PropertyGroup>

<ItemGroup>
Expand Down