Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CanBeEqual: Add special case for Uri.Equals(string) #584

Merged
merged 1 commit into from
Sep 8, 2023
Merged

CanBeEqual: Add special case for Uri.Equals(string) #584

merged 1 commit into from
Sep 8, 2023

Conversation

manfred-brands
Copy link
Member

Fixes #561

mikkelbu
mikkelbu approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice and simple (although a bit confusing behaviour by Uri)

@mikkelbu mikkelbu merged commit 761ff86 into nunit:master Sep 8, 2023
3 checks passed
@mikkelbu mikkelbu added this to the Release 3.7 / 2.7 milestone Sep 8, 2023
@manfred-brands manfred-brands deleted the issue561_UriVsString branch September 9, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.7 / 2.7
Development

Successfully merging this pull request may close these issues.

NUnit2021 error shown when comparing Uri and string
2 participants
@manfred-brands @mikkelbu