Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove name colon on tolerance argument with code fix #688

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Remove name colon on tolerance argument with code fix #688

merged 2 commits into from
Feb 5, 2024

Conversation

verdie-g
Copy link
Contributor

@verdie-g verdie-g commented Feb 4, 2024

Fix #689.

Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. The code changes look good. I only have a small change request for the comment

…elAssertUsageCodeFix.cs

Co-authored-by: Manfred Brands <manfred-brands@users.noreply.github.com>
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @verdie-g and for the review @manfred-brands.

@mikkelbu mikkelbu merged commit d05cb67 into nunit:master Feb 5, 2024
6 checks passed
@mikkelbu mikkelbu added this to the Release 4.1 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect constraint model transformation for named parameters
3 participants