Simplify the ValuesAttribute #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bartleby2718
force-pushed
the
755-Simplify-Values
branch
from
ec838fb
to
d788e51
Compare
Bartleby2718
force-pushed
the
755-Simplify-Values
branch
from
d788e51
to
ae65111
Compare
manfred-brands
requested changes
Jun 11, 2024
src/nunit.analyzers/SimplifyValues/SimplifyValuesAnalyzerConstants.cs
Outdated
Show resolved
Hide resolved
…ad-only property with an initializer
manfred-brands
approved these changes
Jun 18, 2024
Co-authored-by: Manfred Brands <manfred-brands@users.noreply.github.com>
|
Thanks @Bartleby2718, I have merged the PR now. |
|
@manfred-brands Thanks for providing feedback and merging the PR! |
Bartleby2718
added a commit
to Bartleby2718/nunit.analyzers
that referenced
this pull request
Jun 22, 2024
manfred-brands
pushed a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time adding a new diagnostic, please take a closer look at Markdown file changes or strings that users can see. Thanks in advance!