feat: added eslintingore template and PWA options #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included auto generated service worker files when PWA option is selected in .eslintignore
clarkdo
approved these changes
Aug 5, 2021
vinayakkulkarni
suggested changes
Aug 22, 2021
| @@ -103,6 +103,7 @@ module.exports = { | |||
| files: '*', | |||
| filters: { | |||
| '_.eslintrc.js': 'linter.includes("eslint")', | |||
| '_.eslintignore': 'linter.includes("eslint")', | |||
There was a problem hiding this comment.
Instead of adding another file, can't you add sw.js in gitingore?
Cause there are cases where we use prettier, style lint alongside eslint. This approach would also mean that you have to add .prettierignore & .stylelintignore
There was a problem hiding this comment.
There was a problem hiding this comment.
When the files are generated, sw.* is included in the .gitignore already. Although, eslint still runs through and lints the auto generated service worker codes causing the linting error when developing or building.
There was a problem hiding this comment.
The error. @typescript-eslint is whats emitting the error.
This disappears when sw.* is included in the .eslintignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
PWAoption is selected and alsoeslintlint option, eslint logs an error from the auto generated service worker filesw.jsdue to possible conflicting rules..eslintignore
There is no
.eslintignorefile being generated, so a template was created and which includes auto generated service worker files when PWA option is selected.