Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CONTRIBUTING.md #2876

Merged
merged 1 commit into from
Jan 18, 2024
Merged

docs: update CONTRIBUTING.md #2876

merged 1 commit into from
Jan 18, 2024

Conversation

jamestrew
Copy link
Contributor

Better reflect the thoughts in #1228

I feel bad for people submitting PRs for new pickers only to pretty much be insta-closed.

@jamestrew jamestrew merged commit 43cabe5 into master Jan 18, 2024
13 checks passed
@jamestrew jamestrew deleted the docs-contrib branch January 18, 2024 04:18
@Conni2461
Copy link
Member

Conni2461 commented Jan 18, 2024

I dont know about these changes. I dont completely agree with whats written here!
Also why was this self merged without feedback from other contributors within minutes?

@jamestrew
Copy link
Contributor Author

Sorry Conni we can revert this or tweak it should you want to. This hasn't been updated in something like 3 years (except syntax/grammar) and 2 years since the "move out all builtins" discussion started. I felt at the very least it was more accurate than what we already have.

Regarding self-merges, honestly I don't wish to self-merge anything but if I'm being honest, timely feedback is not always reliably there I'm sorry to say. And this is completely understandable considering we're all just volunteering our spare time.

I'm just trying to find the balance between keeping things moving for the sake of the project but also my own motivation level while still respecting the feedback process.

What do have any thoughts how to find this balance?

@Conni2461
Copy link
Member

I felt at the very least it was more accurate than what we already have.

updating this wasnt wrong.

Regarding self-merges, honestly I don't wish to self-merge anything but if I'm being honest, timely feedback is not always reliably there I'm sorry to say. And this is completely understandable considering we're all just volunteering our spare time.

we should take this private but i live in the eu and this was merged within minutes while i was asleep so idk. So yeah we are currently the only 2 ppl left who more or less actively work here, so i suggest we have a little chat, sometime soon, because i am aware that i am not as active as i should be especially on pings. does that work for you?

@jamestrew
Copy link
Contributor Author

sounds good 👍

Conni2461 pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants