Nw19 gyp build #10
Open
Nw19 gyp build #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtg-gg
force-pushed
the
nw19-gyp-build
branch
from
d4fd020 to
a2558c1
Compare
rogerwang
force-pushed
the
nw19
branch
2 times, most recently
from
7186f2b to
bc66ff0
Compare
run nw as node decouple node dll add g_dom_context new mac loop fixup! chromium-integration fixup! new mac loop fix process.title enter node's context before callback chain PromiseRejectCallback
fixup! fix allocator
Or we'll have loop in the list when the async req is inserted again by uv_async_send_nw Fix nwjs/nw.js#2332
src\third_party\node\src\node_revert.cc(15) : warning C4065: switch statement contains 'default' but no 'case' labels
revert f1488bb
Strings in DOM may be converted to two bytes representation, which should be processed as array of `uint16_t` when decoding hex or base64. base64 decoding in Node.js can fallback to a slow implementation to skip invalid characters (i.e. `\0` in this case). This patch can also keep base64 decoding running under the fast implementation. fixed nwjs/nw.js#5069
'component' was defined within NW.js building procedure. However it wasn't defined until including 'common.gypi' when building addons. Conditions within 'variables' cannot use variable within the same level. Moving conditions to 'target_defaults' will make 'component' defined before evaluating the conditions, to prevent addon building failures. fixed nwjs/nw-gyp#96
|
Do we need all the files in build folder? I think only a small portion of it is needed. |
jtg-gg
force-pushed
the
nw19-gyp-build
branch
from
a2558c1 to
abe11ec
Compare
jtg-gg
force-pushed
the
nw19-gyp-build
branch
from
abe11ec to
bece897
Compare
|
I haven't have time to check all the gyp/gypi dependencies |
rogerwang
force-pushed
the
nw19
branch
3 times, most recently
from
e5b22d5 to
ccefbea
Compare
rogerwang
force-pushed
the
nw19
branch
2 times, most recently
from
b8beeac to
89d99fc
Compare
rogerwang
force-pushed
the
nw19
branch
3 times, most recently
from
c5eaeec to
c183b55
Compare
rogerwang
force-pushed
the
nw19
branch
2 times, most recently
from
f0649e9 to
78766fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roger Wang
I propose of copying the chromium build folder into node
and use the common.gypi there
I need to make nwjs build for arm, I usually use cross compile method with linux x64 as the host
the current simplified common.gypi does not work, too many dependencies are needed
so copying the whole build folder is better
I've tested my pull request on win / mac / linux
should be working fine
the only different, when calling build/gyp_chromium use
-I src/third_party/node/build/common.gypi
Jefry