Skip to content

Commit

Permalink
Merge pull request #297 from nyx-space/230-remove-der-dependency
Browse files Browse the repository at this point in the history
Removed der dependency
  • Loading branch information
ChristopherRabotin authored Apr 24, 2024
2 parents 2483f3f + 8ede0d8 commit 926214e
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 165 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ jobs:
- name: Test (default features)
run: cargo test

- name: Test (ASN1)
run: cargo test --features asn1der

- name: Test (UT1)
run: cargo test --features ut1

Expand Down Expand Up @@ -120,8 +117,8 @@ jobs:
- name: Generate coverage report
run: |
cargo llvm-cov clean --workspace
cargo llvm-cov test --no-report --features=std,asn1der -- --test-threads=1
cargo llvm-cov test --no-report --tests --features=std,asn1der -- compile_fail
cargo llvm-cov test --no-report --features=std -- --test-threads=1
cargo llvm-cov test --no-report --tests --features=std -- compile_fail
cargo llvm-cov report --lcov > lcov.txt
env:
RUSTFLAGS: --cfg __ui_tests
Expand Down
4 changes: 1 addition & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ name = "hifitime"
[dependencies]
serde = { version = "1.0.155", optional = true }
serde_derive = { version = "1.0.155", optional = true }
der = { version = "0.7.8", features = ["derive", "real"], optional = true }
pyo3 = { version = "0.21.1", features = [
"extension-module",
"inventory",
Expand Down Expand Up @@ -72,8 +71,7 @@ iai = "0.1"
[features]
default = ["std"]
std = ["serde", "serde_derive", "web-time"]
asn1der = ["der"]
python = ["std", "asn1der", "pyo3", "ut1"]
python = ["std", "pyo3", "ut1"]
ut1 = ["std", "reqwest", "tabled", "openssl"]

[[bench]]
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ In order to provide full interoperability with NAIF, hifitime uses the NAIF algo
+ Minimum Support Rust Version (MSRV) bumped to 1.77.0
+ Major refactoring of the code for ease of maintenance and removal of deprecrated functions from 3.x
+ Centralization of all time scale conversions into the `to_time_scale` function -- huge effort by [@gwbres](https://github.com/gwbres)
+ Removed `der` encoding/decoding for Epoch and Duration.

## 3.9.0

Expand Down
154 changes: 0 additions & 154 deletions src/asn1der.rs

This file was deleted.

3 changes: 0 additions & 3 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,6 @@ pub mod prelude {
};
}

#[cfg(feature = "asn1der")]
pub mod asn1der;

#[cfg(feature = "python")]
pub mod python;

Expand Down

0 comments on commit 926214e

Please sign in to comment.