Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CUDA to languages.yaml #940

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added CUDA to languages.yaml #940

wants to merge 4 commits into from

Conversation

jtmr05
Copy link

@jtmr05 jtmr05 commented Jan 20, 2023

Fixes #902

@jtmr05
Copy link
Author

jtmr05 commented Jan 20, 2023

Fixes #902

@spenserblack
Copy link
Collaborator

Hope you don't mind, edited your initial comment so that it would trigger the issue to be closed on merge.

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The ASCII LGTM. When the Vercel deployment is approved we can view the live preview.

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nevermind 😆

Looks like the ASCII art exceeds our max dimensions.

Please make sure the ASCII art is no more than 40 characters wide.

@jtmr05
Copy link
Author

jtmr05 commented Jan 20, 2023

this should do it

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though CUDA has been added to tokei's languages file, it looks like it's not part of tokei's latest release 😞

But the changes LGTM!

@spenserblack
Copy link
Collaborator

Linking #1152 to PRs and issues that will probably be affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CUDA support
3 participants