fix consensus light client status shows empty peer IDs

oasisprotocol · Oct 19, 2023 · 4d71ae3 · 4d71ae3
1 parent f63c447
commit 4d71ae3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/go/consensus/cometbft/light/p2p/p2p.go b/go/consensus/cometbft/light/p2p/p2p.go
@@ -189,6 +189,8 @@ func (lp *lightClientProvider) Initialized() <-chan struct{} {
 func (lp *lightClientProvider) PeerID() string {
 	peer := lp.getPeer()
 	if peer == nil {
+		// This happens if a provider is not yet uninitialized, or
+		// (unlikely) if a peer was just dropped and no new peer is available.
 		return ""
 	}
 	return peer.String()

diff --git a/go/consensus/cometbft/light/service.go b/go/consensus/cometbft/light/service.go
@@ -106,7 +106,9 @@ func (c *client) GetStatus() (*consensus.LightClientStatus, error) {
 	}
 
 	for _, p := range c.providers {
-		status.PeerIDs = append(status.PeerIDs, p.PeerID())
+		if id := p.PeerID(); id != "" {
+			status.PeerIDs = append(status.PeerIDs, id)
+		}
 	}
 
 	return status, nil