ci: Remove daily artifacts on successful test run #5370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gw0
requested review from
kostko,
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
peternose
reviewed
Sep 20, 2023
| @@ -12,6 +12,9 @@ if [[ $BUILDKITE_RETRY_COUNT == 0 ]]; then | |||
| --scenario_timeout 900m \ | |||
| --scenario e2e/runtime/txsource-multi \ | |||
| "$@" | |||
|
|
|||
| # In case of success daily artifacts are not interesting and can be removed. | |||
| rm -rf /var/tmp/longtests/* | |||
There was a problem hiding this comment.
I guess not, because of failed runs.
There was a problem hiding this comment.
Actually we should, because it doesn't do anything. Nowadays, Buildkite jobs are now much more isolated from other jobs (only the caches are shared), and it can not remove any remains of other jobs.
peternose
approved these changes
Sep 20, 2023
| @@ -12,6 +12,9 @@ if [[ $BUILDKITE_RETRY_COUNT == 0 ]]; then | |||
| --scenario_timeout 900m \ | |||
| --scenario e2e/runtime/txsource-multi \ | |||
| "$@" | |||
|
|
|||
| # In case of success daily artifacts are not interesting and can be removed. | |||
| rm -rf /var/tmp/longtests/* | |||
There was a problem hiding this comment.
I guess not, because of failed runs.
kostko
approved these changes
Sep 20, 2023
gw0
force-pushed
the
gw0/remove-daily-artifacts-on-success
branch
from
40ffed1 to
6c624a2
Compare
gw0
force-pushed
the
gw0/remove-daily-artifacts-on-success
branch
from
6c624a2 to
a64b8e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of success daily artifacts are not interesting and can be removed, otherwise the script will error out before reaching the added line.