[BACKPORT/23.0.x] go/worker: Minor bug fixes #5406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timestamp of the last block lags behind and depends on the consensus layer's speed. As a result, it is not suitable for scheduling backup proposers.
Transition to a new state once all transactions are fetched. This will immediately trigger batch processing.
Calculating the pool rank from roothash events does not prevent backup schedulers from starting when higher-ranked schedulers have already committed to their proposals, especially when the proposer timeout is shorter than the time required to generate a consensus block. Therefore, it is more suitable to estimate the rank from observed executor commitments.
In unit tests, CometBFT typically generates consensus blocks at a rate of 10 per second. However, if consensus timeout occurs in steps RoundStepPropose or RoundStepPrecommitWait, this rate can significantly decrease to just 1 block per second or even worse. If test requires waiting for a few consensus blocks, these delays can accumulate and potentially lead to failures.
Codecov Report
@@ Coverage Diff @@
## stable/23.0.x #5406 +/- ##
================================================
Coverage ? 66.61%
================================================
Files ? 533
Lines ? 56321
Branches ? 0
================================================
Hits ? 37518
Misses ? 14394
Partials ? 4409 |
Why not backport the whole thing? We will need to do it anyway. |
peternose
changed the title
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5404 and #5403.