config/migrate: Automatically configure external P2P addresses for validators #5410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
peternose
as code owners
ptrus
force-pushed
the
ptrus/fix/config-migrate-validator-p2p
branch
from
19cec16 to
b336056
Compare
ptrus
changed the title
ptrus
force-pushed
the
ptrus/fix/config-migrate-validator-p2p
branch
from
b336056 to
1877c5b
Compare
kostko
reviewed
Oct 19, 2023
ptrus
force-pushed
the
ptrus/fix/config-migrate-validator-p2p
branch
from
1877c5b to
b041f6f
Compare
ptrus
commented
Oct 19, 2023
ptrus
force-pushed
the
ptrus/fix/config-migrate-validator-p2p
branch
from
b041f6f to
1f4f23f
Compare
kostko
reviewed
Oct 19, 2023
| // Set P2P registration addresses if not set. | ||
| if _, ok := m(m(newCfg["p2p"])["registration"])["addresses"]; !ok { | ||
| mkSubMap(m(newCfg["p2p"]), "registration") | ||
| m(m(newCfg["p2p"])["registration"])["addresses"] = []string{url.Hostname() + ":9200"} |
There was a problem hiding this comment.
Should this use the value from p2p.port instead of 9200?
There was a problem hiding this comment.
Good idea, also refactored a bit since now the "external_address" is only needed for the "registartion.addresses" part.
ptrus
force-pushed
the
ptrus/fix/config-migrate-validator-p2p
branch
from
1f4f23f to
a15cc39
Compare
ptrus
force-pushed
the
ptrus/fix/config-migrate-validator-p2p
branch
from
a15cc39 to
5f852bb
Compare
kostko
approved these changes
Oct 19, 2023
Codecov Report
@@ Coverage Diff @@
## master #5410 +/- ##
==========================================
+ Coverage 66.43% 66.87% +0.43%
==========================================
Files 533 533
Lines 56329 56348 +19
==========================================
+ Hits 37424 37680 +256
+ Misses 14499 14267 -232
+ Partials 4406 4401 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.