Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/worker: fix storageCommitLatency timing #5428

Closed
wants to merge 1 commit into from
Closed

go/worker: fix storageCommitLatency timing #5428

wants to merge 1 commit into from

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Nov 7, 2023 •
edited
Loading

golangci-lint >=1.55.0 found this. (should also update version used in CI)

kostko
kostko approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like #5426 also includes a similar fix :)

@ptrus
Copy link
Member Author

ptrus commented Nov 7, 2023

I see :D i'll close this then

@ptrus ptrus closed this Nov 7, 2023
@ptrus ptrus deleted the ptrus/fix/storage-commit-latency branch November 7, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@peternose peternose Awaiting requested review from peternose peternose is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptrus @kostko