[BACKPORT/23.0.x] 5426 #5431
Merged
[BACKPORT/23.0.x] 5426 #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The periodic re-attestation happens every hour, while explicitly requested re-attestation takes place approximately every 1 to 2 hours. This results in both re-attestations occurring closely together. To avoid unnecessary re-attestation and re-registration, we extend the periodic re-attestation interval to encompass the worst-case scenario of explicit attestation.
When a node is not a member of the committee, events, commitments, and transactions accumulate in the channels. When the node gets re-elected, it must process these channels first, potentially resulting in delayed submission of its commitments or incorrect discrepancy detection.
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
peternose
added
c:backport
Codecov Report
@@ Coverage Diff @@
## stable/23.0.x #5431 +/- ##
=================================================
+ Coverage 66.29% 66.54% +0.24%
=================================================
Files 533 533
Lines 56352 56365 +13
=================================================
+ Hits 37361 37509 +148
+ Misses 14569 14466 -103
+ Partials 4422 4390 -32
|
kostko
approved these changes
Nov 7, 2023
pro-wh
added a commit
to oasisprotocol/nexus
that referenced
this pull request
Feb 26, 2024
cross-reference: oasisprotocol/oasis-core#5431 Adding this as nilable so we can detect versions below 23.0.3 leaving it out.
pro-wh
added a commit
to oasisprotocol/nexus
that referenced
this pull request
Feb 27, 2024
cross-reference: oasisprotocol/oasis-core#5431 Adding this as nilable so we can detect versions below 23.0.3 leaving it out.
pro-wh
added a commit
to oasisprotocol/nexus
that referenced
this pull request
Feb 27, 2024
cross-reference: oasisprotocol/oasis-core#5431 Adding this as nilable so we can detect versions below 23.0.3 leaving it out.
pro-wh
added a commit
to oasisprotocol/nexus
that referenced
this pull request
Feb 27, 2024
cross-reference: oasisprotocol/oasis-core#5431 Adding this as nilable so we can detect versions below 23.0.3 leaving it out.
pro-wh
added a commit
to oasisprotocol/nexus
that referenced
this pull request
Feb 27, 2024
cross-reference: oasisprotocol/oasis-core#5431 Adding this as nilable so we can detect versions below 23.0.3 leaving it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #5426