runtime/keymanager: Support new key manager status fields #5432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
peternose
force-pushed
the
peternose/stable/22.2.x/support-new-km-status-fields
branch
from
e3a385a to
cf9c097
Compare
peternose
added
c:key management
peternose
force-pushed
the
peternose/stable/22.2.x/support-new-km-status-fields
branch
2 times, most recently
from
8e1b058 to
535d064
Compare
kostko
approved these changes
Nov 8, 2023
Codecov Report
@@ Coverage Diff @@
## stable/22.2.x #5432 +/- ##
=================================================
+ Coverage 66.58% 66.72% +0.13%
=================================================
Files 472 472
Lines 51668 51668
=================================================
+ Hits 34404 34473 +69
+ Misses 13035 12959 -76
- Partials 4229 4236 +7 |
This vulnerability does not affect our current use of the library.
This vulnerability is removed in Oasis Core 23.0.x.
Oasis Core 23.0.x introduced support for master secret rotations, adding three new fields to the key manager status. Although these fields are omitted when empty, they can still cause issues. When one of the new key managers registers, the consensus sets the runtime signing key, causing problems for the old key managers. As a result, the old key managers are not able to re-register anymore because enclave re-initialization will fail to verify whether the new policy was published in the consensus layer, due to the inability to decode the key manager status. In contrast, generation and rotation epoch do not create such problems since master secret generations are not enabled by default.
peternose
force-pushed
the
peternose/stable/22.2.x/support-new-km-status-fields
branch
2 times, most recently
from
ba1fe75 to
e0c1cf7
Compare
peternose
force-pushed
the
peternose/stable/22.2.x/support-new-km-status-fields
branch
from
e0c1cf7 to
9f8232c
Compare
peternose
deleted the
peternose/stable/22.2.x/support-new-km-status-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oasis Core 23.0.x introduced support for master secret rotations, adding three new fields to the key manager status. Although these fields are omitted when empty, they can still cause issues. When one of the new key managers registers, the consensus sets the runtime signing key, causing problems for the old key managers. As a result, the old key managers are not able to re-register anymore because enclave re-initialization will fail to verify whether the new policy was published in the consensus layer, due to the inability to decode the key manager status. In contrast, generation and rotation epoch do not create such problems since master secret generations are not enabled by default.
Added also generation and rotation epoch, even though these fields do not cause problems.
Backports: #5421, #5348