go/runtime/host: Add GetActiveVersion to Runtime interface #5535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
peternose
force-pushed
the
peternose/feature/active-version
branch
2 times, most recently
from
811e468
to
87e793d
Compare
kostko
approved these changes
Jan 23, 2024
go/runtime/registry/host.go
Outdated
| @@ -124,6 +124,19 @@ func (n *RuntimeHostNode) WaitHostedRuntime(ctx context.Context) (host.RichRunti | |||
| return n.GetHostedRuntime(), nil | |||
| } | |||
|
|
|||
| // GetActiveVersion returns the version of the active runtime. | |||
| func (n *RuntimeHostNode) GetActiveVersion() (*version.Version, error) { | |||
There was a problem hiding this comment.
Suggested change
| func (n *RuntimeHostNode) GetActiveVersion() (*version.Version, error) { | |
| func (n *RuntimeHostNode) GetHostedRuntimeActiveVersion() (*version.Version, error) { |
peternose
force-pushed
the
peternose/feature/active-version
branch
from
87e793d
to
352f04f
Compare
peternose
force-pushed
the
peternose/feature/active-version
branch
from
352f04f
to
8d1c466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.