Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work to implement Sapphire snap connection #431

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CedarMist
Copy link
Member

@CedarMist CedarMist commented Oct 9, 2024

fixes #389

This provides the decryption keys to snap.

Warning

If an RPC server pretends to implement the MetaMask snap protocol it could trick users into revealing the transaction encryption key.

For this reason, we have to explicitly enable Snap support in the dApp, by passing the enableSapphireSnap option.

Usage:

wrapEthereumProvider(window.ethereum, {enableSapphireSnap:true})

This must only be done if the dApp is sure that the provider it's connecting to is MetaMask.

TODO:

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for oasisprotocol-sapphire-paratime canceled.

Name Link
🔨 Latest commit 1b3fab0
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/6708f72c25062e000805cb82

@CedarMist CedarMist self-assigned this Oct 9, 2024
@CedarMist CedarMist added client javascript Pull requests that update JavaScript code labels Oct 9, 2024
@buberdds buberdds self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client javascript Pull requests that update JavaScript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sapphire-snap integration
2 participants