add host-gateway only when docker server is >= v20 #459
Conversation
|
I still need to add a test to mock out the docker cli |
|
I'm cool with the change! Make sure to update the yarn.lock by running |
# Conflicts: # packages/target-chrome-docker/package.json # packages/target-chrome-docker/src/create-chrome-docker-target.js
|
It seems this causes issues in GH Actions: |
|
I'm not so sure this PR is to blame. I see a similar error happening on a build on the upstream master branch https://github.com/oblador/loki/actions/runs/6707668160/job/18226746902 thoughts? |
|
Merging with master again and we can see if this is just flake :-) |
|
Different error now that seems related: |
|
Sounds good to me and thanks for following up on this! I appreciate it 👍. I don't have time to look into it right now, but I'm wondering if there's some issue with the CI env and the port that docker is using behind the special Do you know what version of docker is being used in the CI env? |
|
Btw, regarding testing, I think it might be better to just have a test matrix for the integration tests rather than mocking stuff. |
This line appears to have been a breaking change and made docker v20+ a hard requirement when using loki. We can check for the version before applying it so as to allow for the docker engine to still run properly for previous versions.
Thanks for taking a look and providing any feedback. Your work here is very much appreciated!