Lock Chrome version in docker tests #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oblador
commented
Oct 31, 2023
| try { | ||
| await execute(dockerPath, ['kill', dockerId]); | ||
| } catch (e) { | ||
| if (e.toString().indexOf('No such container') === -1) { |
There was a problem hiding this comment.
When the container crashes, failing to kill it obscured the real error.
techeverri
approved these changes
Oct 31, 2023
| @@ -43,7 +43,7 @@ const waitOnCDPAvailable = (host, port) => | |||
|
|
|||
| function createChromeDockerTarget({ | |||
| baseUrl = 'http://localhost:6006', | |||
| chromeDockerImage = 'yukinying/chrome-headless-browser-stable', | |||
| chromeDockerImage = 'yukinying/chrome-headless-browser-stable:100.0.4896.127', | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the unit tests used
latestwhich caused them to suddenly fail because Chrome is crashing. Long term we would probably want to investigate why latest version is crashing (if it's an issue with the docker image or with the GitHub Action environment).