Add NotificationClient as feature (#212)

observablehq · Oct 30, 2023 · 82211b8 · 82211b8
1 parent 09901d0
commit 82211b8
Show file tree

Hide file tree

Showing 108 changed files with 320 additions and 119 deletions.
diff --git a/src/parse.js b/src/parse.js
@@ -367,6 +367,7 @@ function parseFeatures(cell, input) {
       cell.fileAttachments = findFeatures(cell, "FileAttachment");
       cell.databaseClients = findFeatures(cell, "DatabaseClient");
       cell.secrets = findFeatures(cell, "Secret");
+      cell.notificationClients = findFeatures(cell, "NotificationClient");
     } catch (error) {
       if (error.node) {
         const loc = getLineInfo(input, error.node.start);
@@ -381,6 +382,7 @@ function parseFeatures(cell, input) {
     cell.fileAttachments = new Map();
     cell.databaseClients = new Map();
     cell.secrets = new Map();
+    cell.notificationClients = new Map();
   }
   return cell;
 }
diff --git a/test/input/notification-client.js b/test/input/notification-client.js
@@ -0,0 +1,3 @@
+{
+    let a = NotificationClient("slack:@claire");
+}
diff --git a/test/output/anonymous-block-cell.js.json b/test/output/anonymous-block-cell.js.json
@@ -27,5 +27,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/anonymous-expression-cell.js.json b/test/output/anonymous-expression-cell.js.json
@@ -15,5 +15,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/anonymous-function.js.json b/test/output/anonymous-function.js.json
@@ -37,5 +37,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/await-block-cell.js.json b/test/output/await-block-cell.js.json
@@ -38,5 +38,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/await-in-arrow-function-expression.js.json b/test/output/await-in-arrow-function-expression.js.json
@@ -48,5 +48,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/await-in-arrow-function.js.json b/test/output/await-in-arrow-function.js.json
@@ -74,5 +74,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/await-in-class.js.json b/test/output/await-in-class.js.json
@@ -88,5 +88,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/await-in-function.js.json b/test/output/await-in-function.js.json
@@ -60,5 +60,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/await-in-markdown.md.json b/test/output/await-in-markdown.md.json
@@ -75,7 +75,8 @@
     ],
     "fileAttachments": [],
     "databaseClients": [],
-    "secrets": []
+    "secrets": [],
+    "notificationClients": []
   },
   "raw": false,
   "references": [
@@ -88,5 +89,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/await-yield.js.json b/test/output/await-yield.js.json
@@ -61,5 +61,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/backslash-after-dollar-markdown.md.json b/test/output/backslash-after-dollar-markdown.md.json
@@ -46,11 +46,13 @@
     ],
     "fileAttachments": [],
     "databaseClients": [],
-    "secrets": []
+    "secrets": [],
+    "notificationClients": []
   },
   "raw": false,
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/backslash-before-dollar-markdown.md.json b/test/output/backslash-before-dollar-markdown.md.json
@@ -46,11 +46,13 @@
     ],
     "fileAttachments": [],
     "databaseClients": [],
-    "secrets": []
+    "secrets": [],
+    "notificationClients": []
   },
   "raw": false,
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/backslash-markdown.md.json b/test/output/backslash-markdown.md.json
@@ -46,11 +46,13 @@
     ],
     "fileAttachments": [],
     "databaseClients": [],
-    "secrets": []
+    "secrets": [],
+    "notificationClients": []
   },
   "raw": false,
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/bare-dynamic-import.js.json b/test/output/bare-dynamic-import.js.json
@@ -20,5 +20,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/basic.db.sql.json b/test/output/basic.db.sql.json
@@ -106,7 +106,8 @@
         ]
       ]
     ],
-    "secrets": []
+    "secrets": [],
+    "notificationClients": []
   },
   "raw": false,
   "references": [
@@ -119,5 +120,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/basic.html.json b/test/output/basic.html.json
@@ -76,7 +76,8 @@
     ],
     "fileAttachments": [],
     "databaseClients": [],
-    "secrets": []
+    "secrets": [],
+    "notificationClients": []
   },
   "raw": false,
   "references": [
@@ -89,5 +90,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/basic.sql.json b/test/output/basic.sql.json
@@ -75,7 +75,8 @@
     ],
     "fileAttachments": [],
     "databaseClients": [],
-    "secrets": []
+    "secrets": [],
+    "notificationClients": []
   },
   "raw": false,
   "references": [
@@ -88,5 +89,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/basic.tex.json b/test/output/basic.tex.json
@@ -91,7 +91,8 @@
     ],
     "fileAttachments": [],
     "databaseClients": [],
-    "secrets": []
+    "secrets": [],
+    "notificationClients": []
   },
   "raw": true,
   "references": [
@@ -110,5 +111,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/bigint-zero.js.json b/test/output/bigint-zero.js.json
@@ -16,5 +16,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/bigint.js.json b/test/output/bigint.js.json
@@ -35,5 +35,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/binary-expression.js.json b/test/output/binary-expression.js.json
@@ -34,5 +34,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/block-leading-comment.js.json b/test/output/block-leading-comment.js.json
@@ -32,5 +32,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/block-trailing-comment.js.json b/test/output/block-trailing-comment.js.json
@@ -32,5 +32,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/catch-clause.js.json b/test/output/catch-clause.js.json
@@ -125,5 +125,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/comment.js.json b/test/output/comment.js.json
@@ -9,5 +9,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/computed-property-name.js.json b/test/output/computed-property-name.js.json
@@ -60,5 +60,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/database-client.js.json b/test/output/database-client.js.json
@@ -72,5 +72,6 @@
       ]
     ]
   ],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/destructured-arrow-with-default.js.json b/test/output/destructured-arrow-with-default.js.json
@@ -70,5 +70,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/destructured-assignment-with-default.js.json b/test/output/destructured-assignment-with-default.js.json
@@ -98,5 +98,6 @@
   ],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/destructured-object-with-default.js.json b/test/output/destructured-object-with-default.js.json
@@ -75,5 +75,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/dynamic-import.js.json b/test/output/dynamic-import.js.json
@@ -25,5 +25,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/empty.js.json b/test/output/empty.js.json
@@ -9,5 +9,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/empty.md.json b/test/output/empty.md.json
@@ -9,5 +9,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }
diff --git a/test/output/expression-trailing-comment.js.json b/test/output/expression-trailing-comment.js.json
@@ -20,5 +20,6 @@
   "references": [],
   "fileAttachments": [],
   "databaseClients": [],
-  "secrets": []
+  "secrets": [],
+  "notificationClients": []
 }