Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Robomimic Policy Training Support #57

Closed

Conversation

ashwin-balakrishna96
Copy link

@ashwin-balakrishna96 ashwin-balakrishna96 commented Mar 3, 2024

There are two main changes here:

  1. Support to specify what trajectory keys to normalize, defaults to the original action and proprio keys.
  2. When creating an interleaved dataset which mixes together multiple individual datasets, dataset statistics used for normalization are combined across all datasets.

@ashwin-balakrishna96 ashwin-balakrishna96 changed the title Add flexibility for what keys to normalize Add Robomimic Integration Support Mar 4, 2024
@kpertsch
Copy link
Collaborator

kpertsch commented Mar 4, 2024

By default I don't think we want to normalize interleaved datasets by their combined statistics -- I think this is a special case for DROID since the mixture is quite homogeneous.
Instead, I would suggest adding an argument to make_interleaved_dataset that allows to overwrite the dataset_statistics and just gets passed through to make_rlds_dataset -- that seems more general.

@ashwin-balakrishna96
Copy link
Author

Yep makes sense, I can fix this later today.

@ashwin-balakrishna96
Copy link
Author

@kpertsch this is fixed now, let me know if there is anything else needed to merge. The default behavior should leave all normalization unchanged from what it was originally.

@ashwin-balakrishna96 ashwin-balakrishna96 changed the title Add Robomimic Integration Support Add Robomimic Policy Training Support Mar 7, 2024
@kpertsch
Copy link
Collaborator

Moved most of the changes here to #62 (couldn't figure out how to modify this PR)
-- closing this PR.

@kpertsch kpertsch closed this Mar 11, 2024
WenchangGaoT pushed a commit to WenchangGaoT/octo1 that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants