Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue ID should be a long #2962

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Issue ID should be a long #2962

wants to merge 1 commit into from

Conversation

kzu
Copy link
Contributor

@kzu kzu commented Aug 27, 2024

According to the documentation at https://docs.github.com/en/rest/issues/issues.

Fixes #2351 for issue ids.

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

According to the documentation at https://docs.github.com/en/rest/issues/issues.

Fixes octokit#2351 for issue ids.
@kfcampbell
Copy link
Member

This was already done in #2890. You've changed issue number, which is the "2351" in the linked issue https://github.com/octokit/octokit.net/issues/2351. The issue number increments from 1 for each new repository, and can safely be described with an integer.

@kzu
Copy link
Contributor Author

kzu commented Aug 27, 2024

image

vs

image

either one or the other is the wrong type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🛑 Blocked/Awaiting Response
Development

Successfully merging this pull request may close these issues.

GitHub IDs have exceeded Int32.MaxValue; Octokit uses int
2 participants