Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for service revision existence #680

Merged
merged 9 commits into from
Aug 27, 2024

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Aug 26, 2024

Contents (#680)

IMPORTANT: There is 1 breaking change.

Enhancements

  • 💥 BREAKING CHANGE: Use cloud URIs by default for datasets in output manifests
  • Add comments around checking for service revision existence
  • Improve error when octue.services topic doesn't exist

Fixes

  • Raise error if service revision subscription doesn't exist when no service registry is in use
  • Remove octue.services prefix from subscription names

Refactoring

  • Avoid repeated conversion to Pub/Sub ID for a service

Upgrade instructions

💥 Use cloud URIs by default for datasets in output manifests

Set use_signed_urls_for_output_datasets to True in the app configuration to keep using signed URLs for datasets in output manifests.

BREAKING CHANGE: Set `use_signed_urls_for_output_datasets` to `True` in the app configuration to keep using signed URLs for datasets in output manifests.
@cortadocodes cortadocodes self-assigned this Aug 26, 2024
@cortadocodes cortadocodes merged commit d948b8f into main Aug 27, 2024
5 checks passed
@cortadocodes cortadocodes deleted the check-for-service-revision-existence branch August 27, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant