Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odigos UI beta #1744

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Odigos UI beta #1744

wants to merge 20 commits into from
+40,668 −16,632

Commits on Nov 12, 2024

  1. Odigos UI beta (#1739) 

    Co-authored-by: Ben Elferink <ben.elferink@icloud.com>
Co-authored-by: Tamir David <tamir@odigos.io>
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Co-authored-by: yodigos <yoav@odigos.io>
Co-authored-by: Mike Dame <mike@odigos.io>
Co-authored-by: alonbraymok <alonbraymok007@gmail.com>
    @alonkeyval @BenElferink
    @tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok
    9 people authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b6f71fa View commit details
    Browse the repository at this point in the history

  2. [GEN-1695]: overview filtering (#1740) 

    Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
    @BenElferink @alonkeyval
    BenElferink and alonkeyval authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b553cda View commit details
    Browse the repository at this point in the history

  3. Fixed conf with filters (#1742) 

    Co-authored-by: Ben Elferink <ben.elferink@icloud.com>
Co-authored-by: Tamir David <tamir@odigos.io>
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Co-authored-by: yodigos <yoav@odigos.io>
Co-authored-by: Mike Dame <mike@odigos.io>
Co-authored-by: alonbraymok <alonbraymok007@gmail.com>
    @alonkeyval @BenElferink
    @tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok
    9 people authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    7a5d4b6 View commit details
    Browse the repository at this point in the history

  4. Fixed conf with filters (#1743) 

    Co-authored-by: Ben Elferink <ben.elferink@icloud.com>
Co-authored-by: Tamir David <tamir@odigos.io>
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Co-authored-by: yodigos <yoav@odigos.io>
Co-authored-by: Mike Dame <mike@odigos.io>
Co-authored-by: alonbraymok <alonbraymok007@gmail.com>
    @alonkeyval @BenElferink
    @tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok
    9 people authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a109419 View commit details
    Browse the repository at this point in the history

  5. merge dev (#1745) 

    Co-authored-by: Ben Elferink <ben.elferink@icloud.com>
Co-authored-by: Tamir David <tamir@odigos.io>
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Co-authored-by: yodigos <yoav@odigos.io>
Co-authored-by: Mike Dame <mike@odigos.io>
Co-authored-by: alonbraymok <alonbraymok007@gmail.com>
    @alonkeyval @BenElferink
    @tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok
    9 people authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    4b9b73a View commit details
    Browse the repository at this point in the history

  6. Merge dev (#1746) 

    Co-authored-by: Ben Elferink <ben.elferink@icloud.com>
Co-authored-by: Tamir David <tamir@odigos.io>
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Co-authored-by: yodigos <yoav@odigos.io>
Co-authored-by: Mike Dame <mike@odigos.io>
Co-authored-by: alonbraymok <alonbraymok007@gmail.com>
    @alonkeyval @BenElferink
    @tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok
    9 people authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    bebba92 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. merge dev (#1747) 

    Co-authored-by: Ben Elferink <ben.elferink@icloud.com>
Co-authored-by: Tamir David <tamir@odigos.io>
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Co-authored-by: yodigos <yoav@odigos.io>
Co-authored-by: Mike Dame <mike@odigos.io>
Co-authored-by: alonbraymok <alonbraymok007@gmail.com>
    @alonkeyval @BenElferink
    @tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok
    9 people authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5959df5 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. [GEN-1705]: fast-select for sources (#1749) 

    Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
    @BenElferink @alonkeyval
    BenElferink and alonkeyval authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    80df692 View commit details
    Browse the repository at this point in the history

  2. [GEN-1666]: multi-source control (delete many) (#1750) 

    Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
    @BenElferink @alonkeyval
    BenElferink and alonkeyval authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    539888b View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. [GEN-1709]: added a notification manager (#1753) 

    Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
    @BenElferink @alonkeyval
    BenElferink and alonkeyval authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    735ff63 View commit details
    Browse the repository at this point in the history

  2. [GEN-1715]: cleared all errors from styled-components (#1763)

    @BenElferink
    BenElferink authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    484280a View commit details
    Browse the repository at this point in the history

  3. [GEN-1702] Add odigos UI beta flag (#1760) 

    This pull request introduces several changes to the `cli/cmd/ui.go` and
`frontend` directories, focusing on adding support for a beta UI,
enhancing instrumentation labeling, and refactoring the code to use the
Gin framework for HTTP handling.

### Support for Beta UI:
* Added a new constant `betaDefaultPort` and modified the `uiCmd` to
include a `beta` flag that allows port-forwarding the beta UI pod on
port 3001. (`cli/cmd/ui.go`)
[[1]](diffhunk://#diff-bdc4ded2bf4628241563326d5d7b0443b57d2d37b674014da632b14b78a1c309R29)
[[2]](diffhunk://#diff-bdc4ded2bf4628241563326d5d7b0443b57d2d37b674014da632b14b78a1c309R55-L61)
[[3]](diffhunk://#diff-bdc4ded2bf4628241563326d5d7b0443b57d2d37b674014da632b14b78a1c309L156-R166)
* Updated the `frontend/main.go` to support running a separate server
for the beta UI, including embedding the beta UI files and handling
GraphQL requests. (`frontend/main.go`)
[[1]](diffhunk://#diff-3157268136b8d5514c0baed4c63042c62e3a16048a0346448241152dcd66b209R45-R52)
[[2]](diffhunk://#diff-3157268136b8d5514c0baed4c63042c62e3a16048a0346448241152dcd66b209R61-R71)
[[3]](diffhunk://#diff-3157268136b8d5514c0baed4c63042c62e3a16048a0346448241152dcd66b209R111-R160)
[[4]](diffhunk://#diff-3157268136b8d5514c0baed4c63042c62e3a16048a0346448241152dcd66b209L207-R263)
[[5]](diffhunk://#diff-3157268136b8d5514c0baed4c63042c62e3a16048a0346448241152dcd66b209R274-R275)
[[6]](diffhunk://#diff-3157268136b8d5514c0baed4c63042c62e3a16048a0346448241152dcd66b209R321-R325)
[[7]](diffhunk://#diff-3157268136b8d5514c0baed4c63042c62e3a16048a0346448241152dcd66b209R343-R358)

### Instrumentation Labeling Enhancements:
* Renamed `WorkloadLabeled` to `AppInstrumentationLabeled` and
introduced new fields `NsInstrumentationLabeled` and
`InstrumentationEffective` to track instrumentation status more
accurately. (`frontend/endpoints/applications.go`)
[[1]](diffhunk://#diff-56e335a7772d748ae7b495448e4a634d84785cf2a7fb05f3d8dec47e2b44478bL37-R39)
[[2]](diffhunk://#diff-56e335a7772d748ae7b495448e4a634d84785cf2a7fb05f3d8dec47e2b44478bR116-R128)
[[3]](diffhunk://#diff-56e335a7772d748ae7b495448e4a634d84785cf2a7fb05f3d8dec47e2b44478bL128-R143)
[[4]](diffhunk://#diff-56e335a7772d748ae7b495448e4a634d84785cf2a7fb05f3d8dec47e2b44478bL153-R168)
[[5]](diffhunk://#diff-56e335a7772d748ae7b495448e4a634d84785cf2a7fb05f3d8dec47e2b44478bL178-R193)
* Modified the logic to determine if the entire namespace is
instrumented and updated the response accordingly.
(`frontend/endpoints/applications.go`)

### Refactoring to Use Gin Framework:
* Updated several endpoints to use the Gin framework for handling HTTP
requests, improving the structure and maintainability of the code.
(`frontend/endpoints/config.go`, `frontend/endpoints/destinations.go`,
`frontend/endpoints/namespaces.go`, `frontend/endpoints/sources.go`)
[[1]](diffhunk://#diff-b04460d41d47aa6ee24a85a55e467cdf997da42e7f6da57e190b8e8b2d08840dR7-R9)
[[2]](diffhunk://#diff-b04460d41d47aa6ee24a85a55e467cdf997da42e7f6da57e190b8e8b2d08840dL25-R37)
[[3]](diffhunk://#diff-c1671317c3a61839657a19f4a5f3a466d214f54a2a249a252dfa006a7050cac8L7-R9)
[[4]](diffhunk://#diff-1878fe0d154a7e1bf75befd5acc7e63fddcff0648bff1ec9222a1e33ef0c8baaL77-L116)
[[5]](diffhunk://#diff-eb60fd5fafb8fc63f42d4cbf9a4ca5f1e06481ab2d068f942631667f3ac22688L89-R95)

### Dockerfile Update:
* Added a new copy command to include additional dependencies in the
Docker build process. (`frontend/Dockerfile`)

These changes collectively improve the functionality and maintainability
of the code, providing better support for a beta UI and enhancing the
instrumentation labeling mechanism.

---------

Co-authored-by: Ben Elferink <ben.elferink@icloud.com>
Co-authored-by: Tamir David <tamir@odigos.io>
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Co-authored-by: yodigos <yoav@odigos.io>
Co-authored-by: Mike Dame <mike@odigos.io>
Co-authored-by: alonbraymok <alonbraymok007@gmail.com>
    @alonkeyval @BenElferink
    @tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok
    9 people authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    34c2c74 View commit details
    Browse the repository at this point in the history

  4. [GEN-1717]: Action header-node border width (#1764) 

    Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
    @BenElferink @alonkeyval
    BenElferink and alonkeyval authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    ed0080c View commit details
    Browse the repository at this point in the history

  5. [GEN-1720]: Fixed modal layout (#1766) 

    Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
    @BenElferink @alonkeyval
    BenElferink and alonkeyval authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    1bafe47 View commit details
    Browse the repository at this point in the history

  6. [GEN-1721]: Close search & filter on press ESCAPE (#1767) 

    Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
    @BenElferink @alonkeyval
    BenElferink and alonkeyval authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    7098118 View commit details
    Browse the repository at this point in the history

  7. [GEN-1722]: Filter button weird focus-UI (#1768) 

    Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
    @BenElferink @alonkeyval
    BenElferink and alonkeyval authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    e9fa5d7 View commit details
    Browse the repository at this point in the history

  8. [GEN-1718]: Notification icon BG (as per Figma) (#1765) 

    Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
    @BenElferink @alonkeyval
    BenElferink and alonkeyval authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    a8f6655 View commit details
    Browse the repository at this point in the history

  9. [GEN-1716]: fixed ReactFlow "fit to view" (#1769) 

    Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
    @BenElferink @alonkeyval
    BenElferink and alonkeyval authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    293949a View commit details
    Browse the repository at this point in the history

  10. Fixed ui broken (#1771) 

    Co-authored-by: Ben Elferink <ben.elferink@icloud.com>
Co-authored-by: Tamir David <tamir@odigos.io>
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Co-authored-by: yodigos <yoav@odigos.io>
Co-authored-by: Mike Dame <mike@odigos.io>
Co-authored-by: alonbraymok <alonbraymok007@gmail.com>
    @alonkeyval @BenElferink
    @tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok
    9 people authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    4b7fc72 View commit details
    Browse the repository at this point in the history

  11. [GEN-1726]: fix $props for Text component (#1772) 

    Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
    @BenElferink @alonkeyval
    BenElferink and alonkeyval authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    82cec8e View commit details
    Browse the repository at this point in the history