[FIX] runbot: avoid traceback when forcing a preparing batch #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When forcing a new batch on a bundle the _force method does not return a batch leading to a traceback in the force_bundle route.
Xavier-Do
reviewed
Feb 28, 2023
Comment on lines
+213
to
+216
| if batch: | ||
| batch._log('Batch forced by %s', request.env.user.name) | ||
| batch._prepare(auto_rebase) | ||
| return werkzeug.utils.redirect('/runbot/batch/%s' % batch.id) |
There was a problem hiding this comment.
I think that we should actually return self.last_batch in the _forcemethod.
in this case this will redirect to the existing batch, but also prepare it immediately without waiting the full time.
In this case, we will also need to check for the state in _prepare
if not self.state == "preparing":
return
Or if you prefer to avoid to change this behaviour, we can also return the redirect in all case but fallbacking on last_batch if batch is None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When forcing a new batch on a bundle the _force method does not return a batch leading to a traceback in the force_bundle route.