Fix Tuning issue with small values (Addressing tuning range) #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bench: 1246812
FauziAkram
changed the title
|
I don't think there is an issue to fix, this must be done by the person who tunes this, i.e. transform internally the parameter before passing it on the SPSA. See also #4776 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix for the problem. (My other solution is #4776 )
This time, I address the tuning range, as recommended by @ppigazzini
You're welcome to pick either of the two solutions.
P.s: I re-opened the PR to rebase on master, and fix some issues mentioned by Uniqp