Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust LMR with correction history #5727

Closed
wants to merge 1 commit into from

Conversation

xu-shawn
Copy link
Contributor

A positive constant increase in base reduction is applied to counter the decrease in average reduction from this tweak.

Passed STC:
LLR: 2.98 (-2.94,2.94) <0.00,2.00>
Total: 109216 W: 28415 L: 27989 D: 52812
Ptnml(0-2): 310, 12848, 27911, 13184, 355
https://tests.stockfishchess.org/tests/view/6760bb0e86d5ee47d9542f26

Passed LTC:
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 66918 W: 17073 L: 16694 D: 33151
Ptnml(0-2): 33, 7175, 18666, 7550, 35
https://tests.stockfishchess.org/tests/view/6761e10f86d5ee47d95431fa

bench 1079115

Copy link

github-actions bot commented Dec 18, 2024

clang-format 18 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/noble/clang-format-18.

(execution 12405451763 / attempt 1)

@mstembera
Copy link
Contributor

Congrats! Perhaps I'm a bit old school but I really dislike returning auto. Not being able to immediately know what is being returned unnecessarily eats up brain cycles while reading code. Curious what others think.

@xu-shawn
Copy link
Contributor Author

Maybe it would be better to give correction score a type alias? that could also save the template for eval correction

@Disservin
Copy link
Member

correction value is just a dumb int, no need for any template or big abstraction imo

@ehsanrashid
Copy link

why use std::abs()
r -= std::min(std::abs(correctionValue) / 32768, 2048);

is it not better to use the raw value ?

@cj5716
Copy link
Contributor

cj5716 commented Dec 19, 2024

std::abs tells us the magnitude of the correction (ie, how unstable the position is)

@Disservin Disservin added 🚀 gainer Gains elo to be merged Will be merged shortly labels Dec 22, 2024
@Disservin Disservin closed this in e7e78aa Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 gainer Gains elo to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants