Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Turkish Translation #189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

emirhnkoc
Copy link

@emirhnkoc emirhnkoc commented Sep 13, 2024

Summary by Sourcery

Introduce Turkish language support by updating language mappings and options in the application.

New Features:

  • Add Turkish language support to the application.

Copy link

sourcery-ai bot commented Sep 13, 2024

Reviewer's Guide by Sourcery

This pull request adds support for the Turkish language to the YouTube downloader GUI application. The changes involve updating two Python files to include Turkish language options in the language selection functionality.

File-Level Changes

Change Details Files
Add Turkish language support to the language selection functionality
  • Include Turkish language code 'tr_TR' in the supported languages dictionary
  • Map 'tr_TR' to wx.LANGUAGE_TURKISH constant
  • Add Turkish language option to the language selection dropdown
youtube_dl_gui/app.py
youtube_dl_gui/optionsframe.py

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @emirhnkoc - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Have you included all necessary localization files and resources for the Turkish translation?
  • Please ensure that the Turkish translation has been tested in the UI to confirm it displays correctly and doesn't cause any layout issues.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant