Fix higher order types crashes on immutable php types

olivernybroe · Oct 12, 2021 · 8871013 · 8871013
1 parent ce5beff
commit 8871013
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,10 +3,12 @@
 # collections-intellij Changelog
 
 ## [Unreleased]
+### Fixed
+- Fixed immutable php type issues
 
 ## [0.3.4]
-### Fixed
-- Fixed recursive collection on variables with no types
+### Fixed
+- Fixed recursive collection on variables with no types
 - Fix higher order type provider when no types are possible
 
 ## [0.3.3]

diff --git a/gradle.properties b/gradle.properties
@@ -3,7 +3,7 @@
 
 pluginGroup = dev.nybroe.collector
 pluginName = Collector
-pluginVersion = 0.3.4
+pluginVersion = 0.3.5
 
 # See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
 # for insight into build numbers and IntelliJ Platform versions.

diff --git a/src/main/kotlin/dev/nybroe/collector/types/HigherOrderTypeProvider.kt b/src/main/kotlin/dev/nybroe/collector/types/HigherOrderTypeProvider.kt
@@ -58,8 +58,9 @@ class HigherOrderTypeProvider : PhpTypeProvider4 {
         // Resolve type of the signature.
         val type = PhpIndex.getInstance(project)
             .getBySignature(signature.split('|')[0])
-            .map { it.type }
-            .reduceOrNull { acc, phpType -> acc.add(phpType) }
+            .map { PhpType.builder().add(it.type) }
+            .reduceOrNull { acc, phpType -> acc.merge(phpType) }
+            ?.build()
             ?.global(project)
 
         if (type === null) return null