Fix/callable protocols 2 #599
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 6492 6493 +1
=========================================
+ Hits 6492 6493 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| Fixed | ||
| ^^^^^ | ||
| - Fix callable protocol inheritance. |
There was a problem hiding this comment.
v4.34.0 hasn't been released yet, so this entry should be there instead of a new v4.34.1 section. Also please add a link to this pull request.
| from jsonargparse._parameter_resolvers import get_signature_parameters | ||
| from jsonargparse._postponed_annotations import get_return_type | ||
|
|
||
| if not inspect.isclass(value): | ||
| return False | ||
| members = 0 | ||
| for name, _ in inspect.getmembers(protocol, predicate=inspect.isfunction): | ||
| if name.startswith("_"): | ||
| if name.startswith("_") and name not in allowed_dunder_methods: |
There was a problem hiding this comment.
Give me some time and I analyze the dunder methods in general and maybe in this pull request we do more than __call__.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
|
|
||
| class CallableInterface(Protocol): | ||
| def __call__(self, items: List[float]) -> List[float]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note test
I added some tests for callable protocols. One question that came up is whether functions should be checked against the protocol. Currently that test is failing, here is the example: The result is: |
What does this PR do?
Fixes callable protocol inheritance by allowing a list of private methods to be considered when matching signatures for inheritance of subclasses. The set of
allowed_dunder_methodscurrently only contains the__call__method.Fixes #595
Before submitting