fix stabilization of objectives

onclave · Sep 21, 2020 · 8fcda18 · 8fcda18
1 parent 21cfe2d
commit 8fcda18
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -59,7 +59,7 @@ To use it as a maven dependency add the following to your `pom.xml` file:
         <dependency>
             <groupId>com.debacharya</groupId>
             <artifactId>nsgaii</artifactId>
-            <version>3.1.1</version>
+            <version>3.1.3</version>
         </dependency>
     </dependencies>
 ```

diff --git a/pom.xml b/pom.xml
@@ -14,7 +14,7 @@
 
     <groupId>com.debacharya</groupId>
     <artifactId>nsgaii</artifactId>
-    <version>3.1.1</version>
+    <version>3.1.3</version>
     <packaging>jar</packaging>
 
     <inceptionYear>2019</inceptionYear>

diff --git a/src/main/java/com/debacharya/nsgaii/termination/StabilizationOfObjectives.java b/src/main/java/com/debacharya/nsgaii/termination/StabilizationOfObjectives.java
@@ -65,18 +65,13 @@ public boolean shouldRun(Population population, int generationCount, int maxGene
 			this.avgObjectives.size()
 		);
 
-		for(int i = 1; i < avgObjectivesToConsider.size(); i++) {
-
-			double diff = Math.abs(avgObjectivesToConsider.get(i - 1) - avgObjectivesToConsider.get(i));
-
+		for(int i = 1; i < avgObjectivesToConsider.size(); i++)
 			if((this.shouldRoundOff
 				? Service.roundOff(
-				diff,
-				this.roundOffDecimalPlace
-			) : diff) > this.stabilizationThreshold)
+					Math.abs(avgObjectivesToConsider.get(i - 1) - avgObjectivesToConsider.get(i)),
+					this.roundOffDecimalPlace
+				) : Math.abs(avgObjectivesToConsider.get(i - 1) - avgObjectivesToConsider.get(i))) > this.stabilizationThreshold)
 				return true;
-		}
-
 
 		return false;
 	}