Hosting UI, First draft #906
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Kiet <hoakiet98@gmail.com>
ngobzin11
reviewed
Dec 16, 2024
packages/hosting/src/api/zonke.ts
Outdated
Comment on lines
24
to
40
| export interface DeployOptions { | ||
| environmentId: string; | ||
| buildOutputDirectory: string; | ||
| message?: string; | ||
| } | ||
|
|
||
| export async function deploy(options: DeployOptions) { | ||
| const { environmentId, buildOutputDirectory, message } = options; | ||
|
|
||
| return deployToPreviewEnvironment({ | ||
| environmentId, | ||
| buildOutputDirectory, | ||
| message, | ||
| // Default to 60 seconds for upload link expiration | ||
| uploadLinkExpirationOverride: 60, | ||
| }); | ||
| } |
There was a problem hiding this comment.
I had to add a packageJsonPath property to support Remix builds. The default build output for Remix does not include the required modules, so we need to copy the package.json path so dependencies can be installed during deployment. See this CLI implementation:
https://github.com/zonke-inc/sdk-ts/blob/main/packages/cli/src/commands.ts#L37-L43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A modal with two states, an initial "create link" state and then a "Copy / Unpublish / Update" state
What is the purpose of this pull request?