Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object refactoring in citation processing #3481

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joachim-danswer
Copy link
Contributor

Description

Homogenization of 'final_search...' and 'display_search...' objects (i.e., chunk order post re-ranking/verification vs chunk order post vector search).

How Has This Been Tested?

Tested by using local dummy search. The search order is now correct (as implemented earlier). Impact on CitationInfo still needs to be verified.

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

 - citation_num set to displayed_citation_num, (order in which citation is displayed, not whether it is the first, second, etc. citation mentioned)
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 2:32am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant