feat(helm): add externalHost support for postgres, redis and vespa #3490
+39
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Helm chart design actually partially support usage of external component, especially for storage. Indeed, support for Postgres, Redis, and Vespa dependencies allow
enabled
flag to prevent from deploying such solutions, but external host configuration is not permitted as it is injected into the chart configmap without any possibilities of tuning.This PR proposes to add the following custom values:
And associated template helpers that would decide which host to use in the ConfigMap (created resources if
enabled
,externalHost
otherwise).How Has This Been Tested?
I will test it by deploying the Helm chart locally in both variations: with and without storage components
enabled
to ensure it works as expected.Accepted Risk (provide if relevant)
N/A
Related Issue(s) (provide if relevant)
N/A
Mental Checklist:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.