Fix Timezone Bug

[thotam]

Fix Timezone always UTC

[arukompas]

Hey @thotam , can you explain what exactly is the bug?

[thotam]

Hey @thotam , can you explain what exactly is the bug?

Because when defined timezone in log-viewer.php file is NULL. The config('log-viewer.timezone', 'Value') always return NULL whatever the Value you set is. So $timezone = config('log-viewer.timezone', config('app.timezone', 'UTC')) ?? 'UTC'; will always is UTC
Follow this docs

A default value may also be specified and will be returned if the configuration option does not exist

[arukompas]

hey @thotam I see! Thanks for explaining 😄

First of all, the timezone selection currently works as expected, even if the log viewer's timezone is set to null, because of the LogViewer::timezone() function taking care of defaulting to the app's timezone and finally to UTC.

log-viewer/src/LogViewerService.php

Lines 28 to 37 in 65d945f

	public function timezone(): string
	{
	if (! isset($this->_cachedTimezone)) {
	$this->_cachedTimezone = config('log-viewer.timezone')
	?? config('app.timezone')
	?? 'UTC';
	}
	return $this->_cachedTimezone;
	}

And second, you're not supposed to use config() function inside config files, because Laravel does not guarantee any particular loading order for config files, and it could be that log-viewer.php is loaded before app.php is loaded, therefore not able to get the value.

This currently works as intended, so no change necessary. Closing.