Api stateful domains config option #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdebrauwer
changed the title
arukompas
approved these changes
Apr 8, 2024
|
Big thanks @gdebrauwer , this makes perfect sense! Tagged a new release - https://github.com/opcodesio/log-viewer/releases/tag/v3.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a project that runs on 2 domains, I had an issue where the log-viewer API calls failed and caused an 'this action is unauthorized' on the secondary domain. After some digging, I found that I needed to set the
sanctum.statefulconfig option. The problem is that my project does not use Sanctum. I had to create a dummysanctum.phpconfig to create and set that config variable.That's why I propose to make that an option in the log-viewer config so that it can be easily customized even when you don't use Sanctum in your project.
I made the change a non-breaking change by still checking and using
config('sanctum.stateful')if theconfig('log-viewer.api_stateful_domains')is not set.