Update the expand hub template access design #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @gparvin @JustinKuli @yiraeChristineKim |
openshift-ci
bot
requested review from
gparvin,
JustinKuli and
yiraeChristineKim
| When permissions change after a watch has started, authorization is not reassessed until there is a new request, even | ||
| when the token expires. The [kubernetes-dependency-watches](https://github.com/stolostron/kubernetes-dependency-watches) | ||
| library leverages the client-go [RetryWatcher](https://pkg.go.dev/k8s.io/client-go/tools/watch#RetryWatcher) and it does | ||
| not currently error if the user does not have `watch` permissions. For when the watch is first started, |
There was a problem hiding this comment.
Suggested change
| not currently error if the user does not have `watch` permissions. For when the watch is first started, | |
| not currently have an error if the user does not have `watch` permissions. For when the watch is first started, |
mprahl
force-pushed
the
design-expanded-hub-templates-access2
branch
from
c3ee97d
to
fcc5fa0
Compare
yiraeChristineKim
approved these changes
Jul 17, 2024
|
/hold |
|
/cc @qiujian16 |
Relates: https://issues.redhat.com/browse/ACM-12129 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
force-pushed
the
design-expanded-hub-templates-access2
branch
from
fcc5fa0
to
4a5dd10
Compare
|
@yiraeChristineKim I fixed a typo. Could you please take another look? |
|
/unhold |
yiraeChristineKim
approved these changes
Jul 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1f9c7b7
into
open-cluster-management-io:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates:
https://issues.redhat.com/browse/ACM-12129