-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Earn page react-loading-skeleton #581
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Build is failing due to lockfile not being committed to git |
Colors to try: #89B3FB #2871FD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 3 containers
- same height as earn container
Updated it closer to block size. But didn't ask earlier what if we have multiple pools, is it ok to show skeleton just for the first block? Otherwise I think we should change the logic of fetching pools. Screen.Recording.2024-06-28.at.11.38.21.AM.mov |
We will have multiple items here. The size of each box and the spacing between them should be the same. Right now it looks like they are too close |
Do you mean box as Skeleton line? Does each Skeleton line should "close" one pool item? Or three Skeleton lines "closes" all pool items, so I need to make space (between lines) the same as each Skeleton's line height? |
So I made one Skeleton as a one pool, and while it is loading we are showing three of them Screen.Recording.2024-07-01.at.12.31.02.PM.mov |
closes #494
Screen.Recording.2024-06-28.at.9.46.23.AM.mov