Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earn page react-loading-skeleton #581

Merged
merged 8 commits into from
Jul 2, 2024
Merged

Earn page react-loading-skeleton #581

merged 8 commits into from
Jul 2, 2024

Conversation

alekseevaiana
Copy link
Member

@alekseevaiana alekseevaiana commented Jun 18, 2024

closes #494

Screenshot 2024-06-28 at 9 43 45 AM
Screen.Recording.2024-06-28.at.9.46.23.AM.mov

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
od-app ✅ Ready (Inspect) Visit Preview Jul 1, 2024 7:59pm
od-app-hai ✅ Ready (Inspect) Visit Preview Jul 1, 2024 7:59pm
od-app-testnet ✅ Ready (Inspect) Visit Preview Jul 1, 2024 7:59pm

@pi0neerpat
Copy link
Member

Build is failing due to lockfile not being committed to git

@pi0neerpat
Copy link
Member

Colors to try: #89B3FB #2871FD

Copy link
Member

@pi0neerpat pi0neerpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 3 containers
  • same height as earn container

@alekseevaiana
Copy link
Member Author

Updated it closer to block size. But didn't ask earlier what if we have multiple pools, is it ok to show skeleton just for the first block? Otherwise I think we should change the logic of fetching pools.

Screen.Recording.2024-06-28.at.11.38.21.AM.mov

@pi0neerpat
Copy link
Member

pi0neerpat commented Jun 28, 2024

We will have multiple items here. The size of each box and the spacing between them should be the same. Right now it looks like they are too close

@alekseevaiana
Copy link
Member Author

We will have multiple items here. The size of each box and the spacing between them should be the same. Right now it looks like they are too close

Do you mean box as Skeleton line? Does each Skeleton line should "close" one pool item? Or three Skeleton lines "closes" all pool items, so I need to make space (between lines) the same as each Skeleton's line height?

@alekseevaiana
Copy link
Member Author

alekseevaiana commented Jul 1, 2024

So I made one Skeleton as a one pool, and while it is loading we are showing three of them

Screen.Recording.2024-07-01.at.12.31.02.PM.mov

@alekseevaiana alekseevaiana merged commit d3aa0be into dev Jul 2, 2024
8 checks passed
@alekseevaiana alekseevaiana deleted the iana/react-loading branch July 2, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Earn page react-loading-skeleton
2 participants