Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #549: App Speed #603

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Issue #549: App Speed #603

merged 2 commits into from
Jul 2, 2024

Conversation

jahabeebs
Copy link
Member

closes #549

Description

  • Adds preload/preconnect scripts for CSS assets
  • adds async/async defer to third-party JS bundles to prevent blocking of HTML parsing when downloading JS
  • Converted some large png assets to webp
  • Compressed the default vault webp image more to lower the time to first paint
  • Added suspense boundary behind Shared since there are a lot of async operations happening in Shared and we shouldn't block rendering
  • Lazy loading of things not initially needed in the app like components in Shared, token icons, and the Toast container (i've made sure these still appear, like the wrong network toast)
  • Added default width to splash page icon and ImageContainer to prevent layout shift
  • Added react loading skeleton to splash page icon to prevent layout shift

We should still think of a way to optimize the main vault image loading time (closedvault) because it's the most responsible for hurting the score

Screenshots

React loading skeleton prevents layout shifting (network throttled)

nolayoutshifting.mov

Lighhouse score (around 60-70 and production app lighthouse score is around 30-40 according to https://pagespeed.web.dev)

Screenshot 2024-06-28 at 6 46 52 PM

@jahabeebs jahabeebs self-assigned this Jun 28, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
od-app ✅ Ready (Inspect) Visit Preview Jul 2, 2024 7:23pm
od-app-hai ✅ Ready (Inspect) Visit Preview Jul 2, 2024 7:23pm
od-app-testnet ✅ Ready (Inspect) Visit Preview Jul 2, 2024 7:23pm

@jahabeebs jahabeebs merged commit a3e6ebb into dev Jul 2, 2024
6 of 8 checks passed
@pi0neerpat pi0neerpat deleted the feature/549-app-speed branch August 5, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0neerpat pi0neerpat pi0neerpat approved these changes

Assignees

@jahabeebs jahabeebs

Labels
size/L web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QA: App speed
2 participants
@jahabeebs @pi0neerpat