Stats page - total system surplus

[alekseevaiana]

closes #585

Question

Why we add 1 if min decimals <= then format decimals? If we put format decimals, don't we want to be exact this number?
I changed the logic so it doesn't work if format decimals === 0, but let me know if we should change it (hope it breaks nothing else)

Before

After

Screenshot

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
od-app	✅ Ready (Inspect)	Visit Preview	Jul 3, 2024 6:10pm
od-app-hai	✅ Ready (Inspect)	Visit Preview	Jul 3, 2024 6:10pm
od-app-testnet	✅ Ready (Inspect)	Visit Preview	Jul 3, 2024 6:10pm

[pi0neerpat]

Formatting with "OD" should only be added downstream, where it is displayed

[pi0neerpat]

Please verify throughout the app that this doesn't create unintended effects. After testing, please request Jacobs review

[alekseevaiana]

Notes

Testing

I added few checks for formatDataNumber function (run yarn test src/utils/index.test.ts)

How did I test function changes

I checked function with this piece of code checking that new result not causing unexpecting changes.

export function formatDataNumber(
    input: string,
    decimals = 18,
    formatDecimal = 2,
    currency?: boolean,
    compact?: boolean,
    minimumDecimals: number = 0
) {
    if (minimumDecimals >= formatDecimal) {
        let res: number = Number.parseFloat(input)

        if (decimals !== 0) res = Number.parseFloat(utils.formatUnits(input, decimals))

        if (res < 0.01) {
            let resString = res.toFixed(minimumDecimals)
            return `${currency ? '$' : ''}${resString}`
        }

        const oldResult = new Intl.NumberFormat('en-US', {
            minimumFractionDigits: minimumDecimals,
            maximumFractionDigits:
                minimumDecimals >= formatDecimal ? Math.min(minimumDecimals, formatDecimal) + 1 : formatDecimal,
            notation: compact ? 'compact' : 'standard',
            style: currency ? 'currency' : 'decimal',
            currency: 'USD',
        }).format(res)

        const newResult = new Intl.NumberFormat('en-US', {
            minimumFractionDigits: minimumDecimals,
            maximumFractionDigits:
                minimumDecimals > formatDecimal && formatDecimal !== 0
                    ? Math.min(minimumDecimals, formatDecimal) + 1
                    : formatDecimal,
            notation: compact ? 'compact' : 'standard',
            style: currency ? 'currency' : 'decimal',
            currency: 'USD',
        }).format(res)

        if (oldResult !== newResult)
            console.error('newResult !== oldResult', newResult !== oldResult, oldResult, newResult)
    }

    let res: number = Number.parseFloat(input)

    if (decimals !== 0) res = Number.parseFloat(utils.formatUnits(input, decimals))

    if (res < 0.01) {
        let resString = res.toFixed(minimumDecimals)
        return `${currency ? '$' : ''}${resString}`
        // old return
        // return `${currency ? '$' : ''}${formatNumber(res.toString(), formatDecimal)}`
    }
    // console.log(Math.min(minimumDecimals, formatDecimal))

    return new Intl.NumberFormat('en-US', {
        minimumFractionDigits: minimumDecimals,
        maximumFractionDigits:
            minimumDecimals >= formatDecimal && formatDecimal !== 0
                ? Math.min(minimumDecimals, formatDecimal) + 1
                : formatDecimal,
        notation: compact ? 'compact' : 'standard',
        style: currency ? 'currency' : 'decimal',
        currency: 'USD',
    }).format(res)
}

[alekseevaiana]

@pi0neerpat we don't use this function on vaults creation.
Also, I removed 'join testnet' from footer in this PR. Hope that is ok.