Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #607: Add global vault state #608

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

jahabeebs
Copy link
Member

closes #607

Description

  • This properly populates a new globalStateModel object in our state management library with all the vault information for the 84 existing vaults
  • I have it fetching the global vault state every 60 seconds just like the user vaults but maybe we want to change this
  • I have it fetching the vault owners from the API because I assume it's more efficient than doing contract calls but this also means we should probably tweak the bot to allow us to call it with localhost without having to disable CORS
  • I almost was able to fix the bug in Viewing vault as another user #595 with this new object but I still need to tweak it some more

@jahabeebs jahabeebs requested a review from pi0neerpat July 3, 2024 00:01
@jahabeebs jahabeebs self-assigned this Jul 3, 2024
Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
od-app ✅ Ready (Inspect) Visit Preview Jul 3, 2024 0:01am
od-app-hai ✅ Ready (Inspect) Visit Preview Jul 3, 2024 0:01am
od-app-testnet ✅ Ready (Inspect) Visit Preview Jul 3, 2024 0:01am

@github-actions github-actions bot added the size/L label Jul 3, 2024
@jahabeebs jahabeebs changed the title Issue #607: https://github.com/open-dollar/od-app/issues/607 Issue #607: Add global vault state Jul 3, 2024
@github-actions github-actions bot added the web label Jul 3, 2024
@jahabeebs jahabeebs merged commit e7daf53 into dev Jul 3, 2024
10 checks passed
@pi0neerpat pi0neerpat deleted the feature/607-add-global-vault-state branch August 5, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add global vault state
2 participants