fix stability fee by removing multiplication #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pi0neerpat
added a commit
that referenced
this pull request
Aug 1, 2024
pi0neerpat
added a commit
that referenced
this pull request
Aug 1, 2024
* matomo race conditions (#613) * typo fix (#618) * Issue #606: Vaults explorer page (#611) * explore page * explore page more changes * fix explore page * more explore page fixes * revert yarn lock * explore table reorder, external link * add risk status, fix bugs * remove fuul (#620) * bump sdk (#621) * remove maintenance from bolts * add credit guild block (#622) * add credit guild block * update earn block * final copy * api url hotfix * Od-weth QA (#623) * round stability fee * OD_API_URL * New "initializing" loader (#609) * change waiting modal content * put modal content back * show loader if no title, text, hint, hash * rm loader modal from account checkking * close loader popup when vaults is fetched * prettier * fix loader and blinking * rm creating modal * prettier * lin fix * cleanup * Borrow + Deposit tabs cleanup (#631) * shape of tabs * tabs font styles * borders * fix lint warning * cleanup * Address ENS loading skeleton (#632) * add skeleton to vault stats * sidemenu and wallet info navbar * base color for skeleton in vault stats * base color for skeleton in ean page * prettier * Update react, react-router (#602) * widget at v2.10.2 * add yarn.lock * Update react-router to v6 * Update widget to v3 * add mui packages * fix onboarding props issue * yarn lock * make compatible with react router dom v6 * remove lifi widget * remove widget --------- Co-authored-by: jahabeebs <jahgoreds@gmail.com> * Issue #557: View internal balances (#633) * initial balance draft * initial balance draft * bump sdk version * fix lock file * fix lock file * fix lock file * fix vault block issue * fix infinite loop when pushed from other page (#640) * Issue #630: Explore page design improvements (#639) * explore page improvements * reuse function * fix svg rendering issue * fix navigate issue (#643) * Add GRT (#652) * Bump sdk to v1.7.4-rc.3 * lint * Issue #642: Reconnect on refresh (#644) * reconnect on refresh * fix loading logic * bump svg generator (#649) Co-authored-by: Patrick Gallagher <blockchainbuddha@gmail.com> * bump sdk * Replace all 'any' with correct Types (#638) * rm any from global styles: safe ones * global style: unused, wrong and empty * styling any * errors types and events * prettier and earn index strings type * earn and bolts * add pool data type * rm ts-ignore * lint fix * QA: Tracking error, empty vault (#645) * add error message when vault not excists * fix Tracking error * add error color * lint fix * cleanup console.log * App meta tags (#657) * update helmet * meta tags to home page * change home meta tags texts * vaults meta tags * create meta tags component * add tags to earn and stats * add bg to stats page * stats meta * add other meta tags to main pages * prettier * Issue #656 (app PR): country.is failure (#660) * add geoblock * no ip call * consolidate calls * Add PT-rETH PT-wstETH (#661) * update sdk * bump sdk * update icons * QA: Header (#646) * side menu fixed width * side menu display none id screen is wide * fix account arrangement * change camelot link color * fix bg (#659) * fix gnosis safe (#664) * fix stability fee by removing multiplication (#667) (#668) * fix stability fee by removing multiplication * lint cleanup --------- Co-authored-by: Jacob Habib <47253537+jahabeebs@users.noreply.github.com> Co-authored-by: Iana <36742189+alekseevaiana@users.noreply.github.com> Co-authored-by: jahabeebs <jahgoreds@gmail.com>
pi0neerpat
added a commit
that referenced
this pull request
Aug 2, 2024
pi0neerpat
added a commit
that referenced
this pull request
Aug 5, 2024
pi0neerpat
added a commit
that referenced
this pull request
Aug 5, 2024
* matomo race conditions (#613) * typo fix (#618) * Issue #606: Vaults explorer page (#611) * explore page * explore page more changes * fix explore page * more explore page fixes * revert yarn lock * explore table reorder, external link * add risk status, fix bugs * remove fuul (#620) * bump sdk (#621) * remove maintenance from bolts * add credit guild block (#622) * add credit guild block * update earn block * final copy * api url hotfix * Od-weth QA (#623) * round stability fee * OD_API_URL * New "initializing" loader (#609) * change waiting modal content * put modal content back * show loader if no title, text, hint, hash * rm loader modal from account checkking * close loader popup when vaults is fetched * prettier * fix loader and blinking * rm creating modal * prettier * lin fix * cleanup * Borrow + Deposit tabs cleanup (#631) * shape of tabs * tabs font styles * borders * fix lint warning * cleanup * Address ENS loading skeleton (#632) * add skeleton to vault stats * sidemenu and wallet info navbar * base color for skeleton in vault stats * base color for skeleton in ean page * prettier * Update react, react-router (#602) * widget at v2.10.2 * add yarn.lock * Update react-router to v6 * Update widget to v3 * add mui packages * fix onboarding props issue * yarn lock * make compatible with react router dom v6 * remove lifi widget * remove widget --------- Co-authored-by: jahabeebs <jahgoreds@gmail.com> * Issue #557: View internal balances (#633) * initial balance draft * initial balance draft * bump sdk version * fix lock file * fix lock file * fix lock file * fix vault block issue * fix infinite loop when pushed from other page (#640) * Issue #630: Explore page design improvements (#639) * explore page improvements * reuse function * fix svg rendering issue * fix navigate issue (#643) * Add GRT (#652) * Bump sdk to v1.7.4-rc.3 * lint * Issue #642: Reconnect on refresh (#644) * reconnect on refresh * fix loading logic * bump svg generator (#649) Co-authored-by: Patrick Gallagher <blockchainbuddha@gmail.com> * bump sdk * Replace all 'any' with correct Types (#638) * rm any from global styles: safe ones * global style: unused, wrong and empty * styling any * errors types and events * prettier and earn index strings type * earn and bolts * add pool data type * rm ts-ignore * lint fix * QA: Tracking error, empty vault (#645) * add error message when vault not excists * fix Tracking error * add error color * lint fix * cleanup console.log * App meta tags (#657) * update helmet * meta tags to home page * change home meta tags texts * vaults meta tags * create meta tags component * add tags to earn and stats * add bg to stats page * stats meta * add other meta tags to main pages * prettier * Issue #656 (app PR): country.is failure (#660) * add geoblock * no ip call * consolidate calls * Add PT-rETH PT-wstETH (#661) * update sdk * bump sdk * update icons * QA: Header (#646) * side menu fixed width * side menu display none id screen is wide * fix account arrangement * change camelot link color * fix bg (#659) * fix gnosis safe (#664) * fix stability fee by removing multiplication (#667) * fix stability fee by removing multiplication * lint cleanup * fix stability fee by removing multiplication (#667) (#668) * fix stability fee by removing multiplication * lint cleanup * Remove low gas modal (#671) * Remove low gas modal (#672) * fix stability fee by removing multiplication (#667) * fix stability fee by removing multiplication * lint cleanup * Remove low gas modal (#671) * Add ARB-Griff (#665) * update sdk * bump sdk * add arb-griff icon * bump sdk to v1.7.6 * Add Arb-griff (#674) * fix stability fee by removing multiplication (#667) * fix stability fee by removing multiplication * lint cleanup * Remove low gas modal (#671) * Add ARB-Griff (#665) * update sdk * bump sdk * add arb-griff icon * bump sdk to v1.7.6 * Auction fixes (#637) * chains config improvement * Fix auction block * Cleanup payment flow * max amount error handling * lint --------- Co-authored-by: Jacob Habib <47253537+jahabeebs@users.noreply.github.com> Co-authored-by: Iana <36742189+alekseevaiana@users.noreply.github.com> Co-authored-by: jahabeebs <jahgoreds@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stability fee was being multiplied by redemption rate. I removed this to show the correct fees