Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit fixes #54

Merged
merged 6 commits into from
Apr 20, 2024
Merged

Audit fixes #54

merged 6 commits into from
Apr 20, 2024

Conversation

pi0neerpat
Copy link
Member

@pi0neerpat pi0neerpat commented Apr 20, 2024

Fixes Misleading Validity Checks in read Function of ChainlinkRelayer

  • Fixes M02
  • Fixes L06
  • Fixes L07
  • Fixes L08

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dev@48224ad). Click here to learn what that means.
Report is 3 commits behind head on dev.

Files Patch % Lines
src/contracts/oracles/ChainlinkRelayer.sol 0.00% 2 Missing ⚠️
src/contracts/oracles/DenominatedOracle.sol 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev      #54   +/-   ##
======================================
  Coverage       ?   38.79%           
======================================
  Files          ?       10           
  Lines          ?      116           
  Branches       ?        0           
======================================
  Hits           ?       45           
  Misses         ?       71           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0neerpat pi0neerpat changed the title address m2 read logic Audit fixes Apr 20, 2024
Copy link
Member Author

@pi0neerpat pi0neerpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pi0neerpat pi0neerpat merged commit f248fb4 into dev Apr 20, 2024
5 checks passed
@pi0neerpat pi0neerpat deleted the m2-read-logic branch April 20, 2024 21:16
@cupOJoseph cupOJoseph self-assigned this Apr 20, 2024
Copy link
Contributor

@cupOJoseph cupOJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants