Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft]ref: reduce to single loader call #1007

Closed
wants to merge 1 commit into from

Conversation

boranx
Copy link
Member

@boranx boranx commented Sep 19, 2024

Disclaimer: Do not merge! Created for testing purposes

This is to examine how it'd look like if we lean on a single loader call for loading data files: #999

Signed-off-by: boranx <boran.seref@gmail.com>
@boranx
Copy link
Member Author

boranx commented Sep 19, 2024

for posterity, the CI fails because of oci pull-push tests. The acceptance.bats(which contains data load-related tests for contest test) do pass (such as: https://github.com/open-policy-agent/conftest/blob/master/acceptance.bats#L362)
Some folks complained in the past that the opa pull/push works differently than contest push/pull in terms of how the layers look like, which might be related to it.
The usage of .docs is likely to store them in a readable/managed format in the registry, though the engine itself doesn't need it for evaluation.
I'll look into it more deeply when I find some time, but feel free to leave any comments/thoughts that you think might be useful for guidance. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant